[MakerBundle] final class & root namespace configuration#1315
Closed
jrushlow wants to merge 1 commit intosymfony:mainfrom
Closed
[MakerBundle] final class & root namespace configuration#1315jrushlow wants to merge 1 commit intosymfony:mainfrom
jrushlow wants to merge 1 commit intosymfony:mainfrom
Conversation
|
Thanks for the PR 😍 How to test these changes in your application
Diff between recipe versionsIn order to help with the review stage, I'm in charge of computing the diff between the various versions of patched recipes. symfony/maker-bundle1.0 vs 1.61diff --git a/symfony/maker-bundle/1.61/config/packages/maker.yaml b/symfony/maker-bundle/1.61/config/packages/maker.yaml
new file mode 100644
index 0000000..7fd5b34
--- /dev/null
+++ b/symfony/maker-bundle/1.61/config/packages/maker.yaml
@@ -0,0 +1,12 @@
+when@dev:
+ maker:
+ # tell MakerBundle that all of your classes live in an
+ # Acme namespace, instead of the default App
+ # (e.g. Acme\Entity\Article, Acme\Command\MyCommand, etc)
+ root_namespace: 'App'
+
+ # Tell MakerBundle to make all non-entity classes it generates, "final".
+ generate_final_classes: true
+
+ # Tell MakerBundle to make all entities it generates, "final".
+ generate_final_entities: false
diff --git a/symfony/maker-bundle/1.0/manifest.json b/symfony/maker-bundle/1.61/manifest.json
index 7d42386..d8f4d89 100644
--- a/symfony/maker-bundle/1.0/manifest.json
+++ b/symfony/maker-bundle/1.61/manifest.json
@@ -2,5 +2,8 @@
"bundles": {
"Symfony\\Bundle\\MakerBundle\\MakerBundle": ["dev"]
},
- "aliases": ["maker", "generator", "make"]
+ "aliases": ["maker", "generator", "make"],
+ "copy-from-recipe": {
+ "config/": "%CONFIG_DIR%/"
+ }
} |
auto-merge was automatically disabled
August 29, 2024 16:24
Head branch was pushed to by a user without write access
jrushlow
force-pushed
the
feature/maker/finals
branch
from
297247e to
b74c1f2
Compare
Member
|
I'm rather 👎 on this change: that's too much attention given to something that doesn't really matter. People that disagree can always configure on their side. |
auto-merge was automatically disabled
November 4, 2025 11:30
Pull request was closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[make:crud|voter] generate classes with final keyword maker-bundle#1539 introduces 2 new configuration params
generate_final_classes&generate_final_entities[docs] document new config values maker-bundle#1562 documents the changes
Feature available in MakerBundle
v1.61.0https://github.com/symfony/maker-bundle/releases/tag/v1.61.0adds the
root_namespaceconfiguration directive that has been available in Maker sincev1.27.0.PR 1539 implements the
generate_final_*functionality formake:crud&make:voter. To keep that PR relatively small and reviewable, PR's will be made for other makers for releasev1.61.0